Adds verification of TagNode.location_path to the integration tests #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKatzwinkel
reviewed
May 11, 2024
|
lmao |
JKatzwinkel
reviewed
May 11, 2024
integration-tests/utils.py
Outdated
| from typing import Final | ||
|
|
||
| # Neukölln's digest | ||
| PROGRESS_INDICATION_CHARCATERS: Final = "✓→🚴✊★☆⯪𓄁𓅯▶️✴️🪇⚒️🧻🚬🗿🎳⏳🌝☕🐑🐞🌼🪱🌸🏵💮️" |
There was a problem hiding this comment.
the i think fairly standard font i use for code doesn't have a lot of those charcaters...
it's beautiful and actually that makes up for my lack of representing the prevalence of geometric forms on Neukölln bodies. |
includes minor cosmetics applied to scripts.
With each run a randomly selected sample of data from the corpora is tested. The inclusion as integration test is motivated by the fact that a representative coverage in the unit tests would take too much time. At the same time, there are no relevant criteria to curate a subset of documents for testing and such curation would have to be repeated for future extensions of the corpora. A future interface for running these tests could include configuration options to set the sample sizes.
funkyfuture
force-pushed
the
integration-tests-location-path
branch
from
4f1026c
to
2239b76
Compare
|
ACHTUNG! i force-pushed. i'd say we stick with not using |
JKatzwinkel
previously approved these changes
May 12, 2024
|
gonna be afk for a few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the questionable approach that i mentioned earlier. i think it's justified well enough.