Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade black (&& other dependencies) #22

Merged
merged 4 commits into from Nov 19, 2021
Merged

Upgrade black (&& other dependencies) #22

merged 4 commits into from Nov 19, 2021

Conversation

JKatzwinkel
Copy link
Contributor

@JKatzwinkel JKatzwinkel commented Nov 10, 2021

Apparently, there's an issue in typed-ast which causes the version of black to which our dependencies are locked (20.8b1) to crash when running on python 3.9.8 (!!????):

Tbh I don't quite get what exactly is going on but it seems we have 2 options:

  1. either wait for a types-ast release containing the fix in Define _PyUnicode_DecodeUnicodeEscape even on Python 3.6+ python/typed_ast#171
  2. or upgrade to black^=21.10b0 (which doesn't use typed-ast apparently), which in turn requires python^=3.6.2 and also there are other errors all of a sudden, so I ended up just upgrading everything.

I hereby propose the second option.

@funkyfuture
Copy link
Contributor

had you tried to just to poetry update? i'd like to not pin black to a version during its beta phase.

did this also occur locally for you? in this case i'd rather propose a CONTRIBUTING.md and get that right.

@JKatzwinkel
Copy link
Contributor Author

Just doing a poetry update doesn't cut it: https://github.com/JKatzwinkel/delb/runs/4181523684?check_suite_focus=true

@JKatzwinkel
Copy link
Contributor Author

When I first encountered the problem yesterday, it was only in the Github actions CI pipeline logs. Locally, under Python 3.9.7, I had no issues. However, after switching to Python 3.9.8, I can indeed replicate this locally:
Screenshot from 2021-11-11 19-51-50

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@funkyfuture
Copy link
Contributor

i'd like to post the catatonic emoji with the empty eyes.

i'll ignore the problem for a while so it may disappear as it came up.

@funkyfuture
Copy link
Contributor

the next poetry release will offer a dependencies group feature that i need and want to use to put doc related libs into to fix the unit test workflow on GH actions. let's hope the release will not break other things. maybe that feature will help here to.

@JKatzwinkel
Copy link
Contributor Author

ok let's sleep on it

@JKatzwinkel JKatzwinkel changed the base branch from fetch_or_create_by_xpath to main November 12, 2021 12:01
@JKatzwinkel JKatzwinkel changed the base branch from main to fetch_or_create_by_xpath November 12, 2021 12:02
@funkyfuture funkyfuture added the bug Something isn't working label Nov 16, 2021
@funkyfuture funkyfuture added this to the 0.3 milestone Nov 16, 2021
@funkyfuture funkyfuture mentioned this pull request Nov 19, 2021
@funkyfuture funkyfuture merged commit eb38586 into delb-xml:fetch_or_create_by_xpath Nov 19, 2021
@funkyfuture
Copy link
Contributor

@JKatzwinkel please check your local results, mine and the CI's are fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants