Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails 5.2 Docker image #194

Closed
wants to merge 2 commits into from

Conversation

tim-kuntz
Copy link
Contributor

There were 2 issues that were breaking the build and tests.

  1. Updating Ruby Gems itself without specifying a version causes it to update to the latest version which requires Ruby 3. Instead, we specify the latest version compatible with Ruby 2.6.

Compatibility versions found here:
https://rubygems.org/api/v1/versions/rubygems-update.json

  1. The version of Alpine Linux shipping with the Ruby 2.6 image is missing a shared library needed to load nokogiri. Adding gcompat corrects this.

More information found here:
github/pages-gem#839

There were 2 issues that were breaking the build and tests.

1. Updating Ruby Gems itself without specifying a version causes it to
   update to the latest version which requires Ruby 3. Instead, we
   specify the latest version compatible with Ruby 2.6.

Compatibility versions found here:
https://rubygems.org/api/v1/versions/rubygems-update.json

2. The version of Alpine Linux shipping with the Ruby 2.6 image is
   missing a shared library needed to load nokogiri. Adding `gcompat`
   corrects this.

More information found here:
github/pages-gem#839
@tim-kuntz
Copy link
Contributor Author

Closing this for a more complete pull request in #195

@tim-kuntz tim-kuntz closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant