Use TracePoint.allow_reentry to support TracePoint events while eval #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to suppress a warning of the kind on modern rubies: warning: undefining the allocator of T_DATA class Byebug::ThreadsTable warning: undefining the allocator of T_DATA class Byebug::Context
This was referenced Oct 11, 2023
marshall-lee
commented
Oct 11, 2023
Comment on lines
370
to
386
| { | ||
| case HIT_COND_NONE: | ||
| return 1; | ||
| case HIT_COND_GE: | ||
| { | ||
| case HIT_COND_GE: { | ||
| if (breakpoint->hit_count >= breakpoint->hit_value) | ||
| return 1; | ||
| break; | ||
| } | ||
| case HIT_COND_EQ: | ||
| { | ||
| case HIT_COND_EQ: { | ||
| if (breakpoint->hit_count == breakpoint->hit_value) | ||
| return 1; | ||
| break; | ||
| } | ||
| case HIT_COND_MOD: | ||
| { | ||
| case HIT_COND_MOD: { | ||
| if (breakpoint->hit_count % breakpoint->hit_value == 0) | ||
| return 1; | ||
| break; |
There was a problem hiding this comment.
This is not me, it's clang-format.
marshall-lee
commented
Oct 11, 2023
| @@ -658,6 +658,7 @@ void | |||
| Init_byebug_context(VALUE mByebug) | |||
| { | |||
| cContext = rb_define_class_under(mByebug, "Context", rb_cObject); | |||
| rb_undef_alloc_func(cContext); | |||
There was a problem hiding this comment.
Wasn't really needed but the warning is annoying.
|
I have checked this PR in our codebase on some simple examples where Zeitwerk was previously failing and it seems to be working fine. @deivid-rodriguez I know this gem has been essentially unmaintained since 2021 but is there any chance you could take a look? 🙏 |
|
Hello @deivid-rodriguez ! Just to echo @d4rky-pl comment above, could you take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Ruby and gems versions (needed to run a new test case using
TracePointAPI on new Rubies)Undefine alloc funcs of
ContextandThreadsTable. This is to suppress a warning of this kind on modern rubies:Use
TracePoint.allow_reentryto support others'TracePointevents while evaling.Temporarily shut Byebug's
TracePointevent handlers in the thread that issuedallowing_other_threads { ... }to avoid infinite recursion in event handlers.CTX_FL_IGNOREflag was useful here.Add a test case using
TracePoint.new(:class)hook inspired by @fxn's comment Incompatibility with Zeitwerk #564 (comment)Fixes #564