Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

fix(router/Makefile): use pwd since "docker cp" no longer allows "." #2591

Merged
merged 1 commit into from
Nov 26, 2014

Conversation

mboersma
Copy link
Member

This fixes the problem when doing "make build" using Docker 1.3.2. Docker began erroring on "docker cp source ." as of this commit: moby/moby@31d1d73. Luckily the workaround is not difficult and is backward-compatible.

See also b5ba7c4 for a similar change we had to make in deis-builder.

fixes #2594

This fixes the problem when doing "make build" using Docker 1.3.2.
@mboersma mboersma self-assigned this Nov 25, 2014
@mboersma mboersma added this to the v1.1 milestone Nov 25, 2014
@gabrtv
Copy link
Member

gabrtv commented Nov 25, 2014

One day we'll have build-env / runtime-env isolation inside a single Dockerfile and this will all go away (see moby/moby#7149). Until then, LGTM.

@bacongobbler
Copy link
Member

hmm, now the question arises: is 'pwd' or $PWD more portable? One would assume that both act the exact same way. Research time!

EDIT: http://askubuntu.com/a/476633 indicates that both will act the same way in either case (pwd just prints the value of $PWD), however $PWD probably reduces processing time by a few milliseconds since we don't fork the process.

This was more of a educational exercise than anything, not nitpicking your PR.

LGTM!

@mboersma
Copy link
Member Author

@bacongobbler I thought you might bring that up. 💭 I can't tell if either is more portable; they both seem POSIXy and supported by bash and sh. So I am easily persuaded by any good argument here. If we use $PWD elsewhere in Deis, that's good enough for me.

@carmstrong
Copy link
Contributor

I actually prefer pwd here - using $PWD makes me worry that it'll be evaluated before we expect it to be.

mboersma added a commit that referenced this pull request Nov 26, 2014
fix(router/Makefile): use pwd since "docker cp" no longer allows "."
@mboersma mboersma merged commit c23464a into deis:master Nov 26, 2014
@mboersma mboersma deleted the fix-router-build-docker131 branch November 26, 2014 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trouble running tests locally Ubuntu 14.04
4 participants