New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: context usage in k8s code #2405
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
@lucasrod16 I had a deeper look at the k8s package and am now wondering why we even have it. Ignoring some helper functions, it for the most part just wraps a single call to the client set. In a sense it just increases complexity. My suggestion is to remove it and just use the client set directly. |
Removing the k8s package could be something we discuss as a team, but it is out of scope for this PR. This PR is more strictly focused on how context flows through the program to the client set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks fine. I still have some thoughts about using timer.Reset
but we can revisit that at a later PR. It is a lot more valuable to get this merge to unlock a lot of other fixes.
Description
refactor context usage in k8s code
Related Issue
Relates to #2365
Type of change
Checklist before merging