showing configs failing in secrets #1100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runyontr
requested review from
JasonvanBrackel,
RothAndrew,
jeff-mccoy,
YrrepNoj and
Racer159
as code owners
|
Added the |
runyontr
commented
Dec 9, 2022
| } | ||
| template.ProcessYamlFilesInPath(kPath, component, valueTemplate) | ||
|
|
||
| if err := kustomize.BuildKustomization(kPath, destination, manifest.KustomizeAllowAnyDirectory); err != nil { |
There was a problem hiding this comment.
I'm worried about this and remote bases in the airgap. Does the Kustomize build properly replace a kustomize file like this one:
It seems like it now may require connectivity for the kustomize build to access that address.
There was a problem hiding this comment.
We may need to run something like this when it is available or break the build into two steps: kubernetes-sigs/kustomize#3980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Showing error for #1101