feat: Set ByteStream's mime_type attribute for web based resources #7681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Enhances consistency and clarity in handling MIME types in ByteStream across Haystack. ByteStream's
mime_type
attribute gets set properly for web originating ByteStreams. In web originating ByteStream'scontent_type
is still left intact in meta dictionary for backward compatibility.FileTypeRouter
should get mime type fromByteStream
mime type attribute instead of `meta #7633What:
mime_type
attribute of ByteStream instead of indirect storage of MIME types within a meta dictionary. This change allows direct and uniform access to MIME types, simplifying handling for both web resources and local files.How can it be used:
How did you test it:
test_file_router.py
were adjusted to reflect the direct assignment and checking ofmime_type
.mime_type
attribute across components, ensuring accurate management and application for routing and processing.Notes for the reviewer:
mime_type
attribute implementation covers all necessary cases where MIME type information is accessed or modified.meta
dictionary.