Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rollback macos-latest to macos-12 #7597

Merged
merged 1 commit into from Apr 26, 2024
Merged

chore: Rollback macos-latest to macos-12 #7597

merged 1 commit into from Apr 26, 2024

Conversation

vblagoje
Copy link
Member

@vblagoje vblagoje commented Apr 25, 2024

Github macos-latest now points to M1 runners (macos-14-arm64) which is nice but that kills our python version test matrix. Let's rollback to macos-12 until we see what versions of python shall we test if we use macos-latest (has only python 3.10 and after)

More details: https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/
Available macos runners: https://github.com/actions/runner-images/tree/main/images/macos
Avialable python versions on macos-12: https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md#python

@vblagoje vblagoje requested a review from a team as a code owner April 25, 2024 11:36
@vblagoje vblagoje requested review from masci and removed request for a team April 25, 2024 11:36
@vblagoje vblagoje added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Apr 25, 2024
@github-actions github-actions bot added topic:CI 2.x Related to Haystack v2.0 labels Apr 25, 2024
@anakin87
Copy link
Member

It seems solved now: actions/setup-python#850 (comment)

Correctly running workflow: https://github.com/deepset-ai/haystack/actions/runs/8831609353/job/24287039687

@vblagoje
Copy link
Member Author

Niiice thanks for investigation @anakin87 , closing this one then

@vblagoje vblagoje closed this Apr 26, 2024
@vblagoje vblagoje reopened this Apr 26, 2024
@vblagoje vblagoje requested a review from anakin87 April 26, 2024 08:40
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try!
(to fix caching issues)

@vblagoje vblagoje merged commit 36b9a05 into main Apr 26, 2024
16 checks passed
@vblagoje vblagoje deleted the use_macos12 branch April 26, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 ignore-for-release-notes PRs with this flag won't be included in the release notes. topic:CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants