Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error handling when empty query string passed #864

Closed
wants to merge 1 commit into from

Conversation

SogoKato
Copy link

@SogoKato SogoKato commented Nov 19, 2022

This fixes an error that occurs when using query parameter with gin.

Though siw.ErrorHandler returns no value, the template code tries to use the return value.

siw.ErrorHandler(c, fmt.Errorf("Query argument <ParamName> is required, but not found: %s", err), http.StatusBadRequest) (no value) used as valuecompiler[TooManyValues](https://pkg.go.dev/golang.org/x/tools/internal/typesinternal#TooManyValues)

Change of this p-r fixes the error in my environment.

@SogoKato
Copy link
Author

duplicate of #857, close this p-r.

@SogoKato SogoKato closed this Nov 19, 2022
@jamietanna
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants