Make external ref internalization optional #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
suggested changes
Nov 12, 2022
Co-authored-by: Steven Hartland <steven.hartland@multiplay.co.uk>
|
How can I get this merged? |
|
Needs either the owner or one of the collaborators to review, approve and merge. |
|
Hey @kkroo friendly nudge, as I've just seen this again, and I didn't get a reply last time. NP if it's not still a priority for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables the call to
InternalizeRefsby default inGenerateInlinedSpec.Currently, internalizing external references results in broken validator due to getkin/kin-openapi#618 and is unnecessary because of
import-mappingconfiguration feature.Not sure if the call to
InternalizeRefsis an artifact, so added a flag to enable in output options but can remove it all together as well per the maintainers' discretion.