Fix x-go-type-import code generation #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your changes, I've missed it :( |
|
@deepmap-marcinr could you approve and merge it? |
VladimirStepanov
approved these changes
Jul 25, 2022
|
@jamietanna hello! it's very important fix, could you approve and merge it? |
|
Sorry, I'm not a committer on the repo! I believe the primary maintainer is on vacation at the moment. If you need this, it's worth pinning to your fork (https://www.jvt.me/posts/2022/07/07/go-mod-fork/) |
|
Thank you. |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
* Fix x-go-type-import statements * Add better test coverage for x-go-type-import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to use x-go-type-import for my own project, I ran into an issue where it wasn't generating the types. I dug into the code gen and realized that for each schema, request, or response it actually overwrites the import map. The intended behavior, from my understanding, would be to add the imports rather than overwrite. Overall, the change is pretty small, but it is evident that the test case and example missed this. If desired, I can update the test spec and example.