Add option to prefix enum values with their typename #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corani
force-pushed
the
daniel/prefix-enum
branch
from
34b47da
to
be564df
Compare
corani
changed the title
corani
changed the title
jamietanna
reviewed
Jul 11, 2022
pkg/codegen/schema.go
Outdated
| // This is set to true when this enum conflicts with another in terms of | ||
| // TypeNames or when explicitly requested via the | ||
| // `compatibility.always-prefix-enum-values` option. | ||
| PrefixTypename bool |
There was a problem hiding this comment.
Probably makes sense to be:
Suggested change
| PrefixTypename bool | |
| PrefixTypeName bool |
If it's using TypeName
corani
force-pushed
the
daniel/prefix-enum
branch
from
be564df
to
60e0217
Compare
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a compatibility option to always prefix enum values with their typename.
Previously the following spec:
would be generated as:
or in case of conflicts:
This means if you start out without conflicts but introduce conflicts in a later version the generated code unexpectedly changes from under you and you potentially have to fix your code in many places.
When the new option
compatibility.always-prefix-enum-valuesis set totrue, the latter code is always generated.Closes: #625