Allow binding types as parameters through String() methods
#638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fmt.Stringer |
If trying to use a type, such as a UUID in a path parameter, we'd previously receive an error at runtime to say that `types.UUID` isn't supported. As this is a common use case, we should support it. Instead of adding support for it manually, we can instead look at whether the there's a `String` method, and if so use that to serialise the field.
jamietanna
force-pushed
the
defect/string-params
branch
from
4da8556
to
e2c5077
Compare
|
Looks like it may already be covered by #608 ? |
|
@deepmap-marcinr @yangzh-deepmap sorry for the small nudge, but would it be possible to have a look? 🙏 Looks like this will help a few folks! |
This was referenced Jun 27, 2022
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
…#638) If trying to use a type, such as a UUID in a path parameter, we'd previously receive an error at runtime to say that `types.UUID` isn't supported. As this is a common use case, we should support it. Instead of adding support for it manually, we can instead look at whether the there's a `String` method, and if so use that to serialise the field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If trying to use a type, such as a UUID in a path parameter, we'd
previously receive an error at runtime to say that
types.UUIDisn'tsupported.
As this is a common use case, we should support it. Instead of adding
support for it manually, we can instead look at whether the there's a
Stringmethod, and if so use that to serialise the field.