Fix UUID query param binding #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coding.TextUnmarshaler, try to unmarshal, otherwise fallthrough to default case.
|
@deepmap-marcinr Can you please merge this, it is affecting our project as well |
|
@deepmap-marcinr thank you for merging, can you also make a new release please |
|
I'm waiting on a couple of big changes to be finished before pushing another, it will be 1.12 as it adds a bunch of functionality. Can you for now, use a specific SHA in your go.mod? |
Will do, thanks! |
jakmoe
pushed a commit
to jakob-moeller-cloud/octi-sync-server
that referenced
this pull request
Oct 1, 2022
generated due to deepmap/oapi-codegen#623 in upstream oapi
|
Hi any updates on 1.12? My project needs this fix as well. |
|
Just ran into this as well. Looking forward to the fix. Thanks. |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
* Check case where destination object is an array. If obj implements encoding.TextUnmarshaler, try to unmarshal, otherwise fallthrough to default case. * Revert white space deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #616.
Adds a case to check if the destination object is an array and then tries to unmarshal using TextUnmarshaler (which UUID implements). If that fails, fallthrough to default.