Make UUID an alias of uuid.UUID #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of wrapping Google's `uuid.UUID`, and reimplementing the JSON logic, simply make it an alias instead. The current version already leaks the implementation detail, so I don't see any reason to also wrap it, and make its usage harder.
hikhvar
pushed a commit
to hikhvar/oapi-codegen
that referenced
this pull request
Jun 3, 2022
We make heavy use of the new UUID feature introduced in deepmap#571, deepmap#546 and deepmap#556. However, we observed that using a UUID as parameter creates malformed strings in the requests made by the generated clients. This adds a special handling for types.UUID in the StyleParamWithLocation function. I'm not that happy with this approach. I would like to use an interface "MarshalParameter" for this with semantics similar to MarshalJSON. But that doesn't work for aliased types as UUIDs.
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
Instead of wrapping Google's `uuid.UUID`, and reimplementing the JSON logic, simply make it an alias instead. The current version already leaks the implementation detail, so I don't see any reason to also wrap it, and make its usage harder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of wrapping Google's
uuid.UUID, and reimplementing theJSON logic, simply make it an alias instead.
The current version already leaks the implementation detail, so I
don't see any reason to also wrap it, and make its usage harder.
Continuation of #546 and #556.