Added implementation of x-json-ignore #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @deepmap-marcinr, could you please suggest who can check the PR? If it's good - I can work on the tests and other required improvements to make sure it will fit perfectly. |
|
I'm traveling on vacation right now, I'll take a look soon. |
|
Hi @deepmap-marcinr could you please check this one? |
jamietanna
reviewed
Sep 11, 2022
pkg/codegen/schema.go
Outdated
| @@ -465,6 +472,7 @@ func GenFieldsFromProperties(props []Property) []string { | |||
| tags[i] = fmt.Sprintf(`%s:"%s"`, k, fieldTags[k]) | |||
| } | |||
| field += "`" + strings.Join(tags, " ") + "`" | |||
|
|
|||
jamietanna
reviewed
Sep 11, 2022
pkg/codegen/extension.go
Outdated
| @@ -51,3 +52,18 @@ func extExtraTags(extPropValue interface{}) (map[string]string, error) { | |||
| } | |||
| return tags, nil | |||
| } | |||
|
|
|||
| func extParseGoJsonIgnore(extPropValue interface{}) (bool, error) { | |||
|
|
|||
jamietanna
reviewed
Sep 11, 2022
|
I actually thought this change will never be here... That probably will be a pain, but let me try to recall what happened here. |
sparshev
force-pushed
the
json_ignore_extension
branch
from
ddfe504
to
8eb671e
Compare
|
Ok, I removed the logic optimization and left just the code related to the json-ignore. @jamietanna could you please approve the workflows? |
|
I hope it's not another year to wait... |
|
@jamietanna may I ask you to check this again? The workflows seems doesn't want to start until someone will approve them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of x-go-json-ignore to use with GORM when we don't need to serialize specific fields (when ObjectID and Object fields is in the same struct).