Issue with specs with circular references #936
Comments
|
I am also running into the problem with circular references. A configuration setting would be good. Perhaps this commit is helpful |
jamietanna
added a commit
that referenced
this issue
Aug 23, 2023
As noted in #936, we have an issue where a number of circular references may be expected and allowed, so we should provide the ability to configure this, allowing users to decide what makes sense for them. This requires we add an additional method, `LoadSwaggerWithCircularReferenceCount`, as the existing method is part of our public API and we cannot modify it without breaking consumers. This is already available in the version of kin-openapi we're using, we're just configuring it. Closes #936, #957.
jamietanna
added a commit
that referenced
this issue
Aug 23, 2023
As noted in #936, we have an issue where a number of circular references may be expected and allowed, so we should provide the ability to configure this, allowing users to decide what makes sense for them. This requires we add an additional method, `LoadSwaggerWithCircularReferenceCount`, as the existing method is part of our public API and we cannot modify it without breaking consumers. This is already available in the version of kin-openapi we're using, we're just configuring it. Closes #936, #957.
|
Thanks folks, apologies for the delay with this one, it slipped under the radar ahead of the last release - I've raised #1204, and it'll be included in the 1.14.0 release next week 👏 |
jamietanna
added a commit
that referenced
this issue
Aug 23, 2023
As noted in #936, we have an issue where a number of circular references may be expected and allowed, so we should provide the ability to configure this, allowing users to decide what makes sense for them. This requires we add an additional method, `LoadSwaggerWithCircularReferenceCount`, as the existing method is part of our public API and we cannot modify it without breaking consumers. This is already available in the version of kin-openapi we're using, we're just configuring it. Closes #936, #957.
jamietanna
added a commit
that referenced
this issue
Aug 23, 2023
As noted in #936, we have an issue where a number of circular references may be expected and allowed, so we should provide the ability to configure this, allowing users to decide what makes sense for them. This requires we add an additional method, `LoadSwaggerWithCircularReferenceCount`, as the existing method is part of our public API and we cannot modify it without breaking consumers. This is already available in the version of kin-openapi we're using, we're just configuring it. Closes #936, #957.
debuggerpk
pushed a commit
to breuHQ/oapi-codegen
that referenced
this issue
Sep 18, 2023
As noted in deepmap#936, we have an issue where a number of circular references may be expected and allowed, so we should provide the ability to configure this, allowing users to decide what makes sense for them. This requires we add an additional method, `LoadSwaggerWithCircularReferenceCount`, as the existing method is part of our public API and we cannot modify it without breaking consumers. This is already available in the version of kin-openapi we're using, we're just configuring it. Closes deepmap#936, deepmap#957.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Specs with circular references that used to be parsed and generated correctly using version
1.11.0fail parsing when using version1.12.xwith errorkin-openapi bug found: circular schema reference not handledI think the issue is related to getkin/kin-openapi#615
It seems
kin-openapihas madeCircularReferenceCounterconfigurable to work around the problem.It would be great if
oapi-codegencould exposeCircularReferenceCounteras a configuration settingThe text was updated successfully, but these errors were encountered: