Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest version of kin-openapi #957

Closed
mthaak opened this issue Feb 10, 2023 · 2 comments
Closed

Upgrade to latest version of kin-openapi #957

mthaak opened this issue Feb 10, 2023 · 2 comments
Labels
dependencies Pull requests that update a dependency file upstream

Comments

@mthaak
Copy link

mthaak commented Feb 10, 2023

The latest version is v0.114.0 as of the time of writing. oapi-codegen v1.12.4 is still using kin-openapi v0.107.0 but I'm seeing that master is already using v0.112.0 so that looks promising.

This might resolve #936.

Background: getkin/kin-openapi#764.

Thank you!

@yehted
Copy link

yehted commented Mar 3, 2023

I did a go install github.com/deepmap/oapi-codegen/cmd/oapi-codegen@2b52cd5 to get the commit (#953) that bumps kin-openapi to v0.114.0 but the circular reference error (#936) still persists.

jamietanna added a commit that referenced this issue Aug 23, 2023
As noted in #936, we have an issue where a number of circular references
may be expected and allowed, so we should provide the ability to
configure this, allowing users to decide what makes sense for them.

This requires we add an additional method,
`LoadSwaggerWithCircularReferenceCount`, as the existing method is part
of our public API and we cannot modify it without breaking consumers.

This is already available in the version of kin-openapi we're using,
we're just configuring it.

Closes #936, #957.
jamietanna added a commit that referenced this issue Aug 23, 2023
As noted in #936, we have an issue where a number of circular references
may be expected and allowed, so we should provide the ability to
configure this, allowing users to decide what makes sense for them.

This requires we add an additional method,
`LoadSwaggerWithCircularReferenceCount`, as the existing method is part
of our public API and we cannot modify it without breaking consumers.

This is already available in the version of kin-openapi we're using,
we're just configuring it.

Closes #936, #957.
jamietanna added a commit that referenced this issue Aug 23, 2023
As noted in #936, we have an issue where a number of circular references
may be expected and allowed, so we should provide the ability to
configure this, allowing users to decide what makes sense for them.

This requires we add an additional method,
`LoadSwaggerWithCircularReferenceCount`, as the existing method is part
of our public API and we cannot modify it without breaking consumers.

This is already available in the version of kin-openapi we're using,
we're just configuring it.

Closes #936, #957.
jamietanna added a commit that referenced this issue Aug 23, 2023
As noted in #936, we have an issue where a number of circular references
may be expected and allowed, so we should provide the ability to
configure this, allowing users to decide what makes sense for them.

This requires we add an additional method,
`LoadSwaggerWithCircularReferenceCount`, as the existing method is part
of our public API and we cannot modify it without breaking consumers.

This is already available in the version of kin-openapi we're using,
we're just configuring it.

Closes #936, #957.
debuggerpk pushed a commit to breuHQ/oapi-codegen that referenced this issue Sep 18, 2023
As noted in deepmap#936, we have an issue where a number of circular references
may be expected and allowed, so we should provide the ability to
configure this, allowing users to decide what makes sense for them.

This requires we add an additional method,
`LoadSwaggerWithCircularReferenceCount`, as the existing method is part
of our public API and we cannot modify it without breaking consumers.

This is already available in the version of kin-openapi we're using,
we're just configuring it.

Closes deepmap#936, deepmap#957.
@jamietanna
Copy link
Collaborator

Apologies for not closing this at the time, we've since done this a few times!

@jamietanna jamietanna added dependencies Pull requests that update a dependency file upstream labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file upstream
Projects
None yet
Development

No branches or pull requests

3 participants