Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies in go.mod for protobuf #553

Merged
merged 2 commits into from Apr 19, 2022

Conversation

seeforschauer
Copy link
Contributor

@seeforschauer seeforschauer commented Apr 19, 2022

update dependencies to update protobuf version from 1.5.2 to v1.28.0

@seeforschauer seeforschauer changed the title Update dependencies in `go.mod' Update dependencies in go.mod for protobuf Apr 19, 2022
@seeforschauer
Copy link
Contributor Author

Hi @deepmap-marcinr I would love to see this merged, what are your thoughts? It's currently blocking me bcz protobuf is used in https://github.com/tigrisdata/tigrisdb and I've panics in using https://github.com/tigrisdata/tigrisdb

	previously from: "github.com/tigrisdata/tigrisdb-client-go/api/server/v1"
	currently from:  "github.com/tigrisdata/tigrisdb/api/server/v1"
See https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

In the new version of protobuf it's fixed.

@deepmap-marcinr deepmap-marcinr merged commit 3c2bed4 into deepmap:master Apr 19, 2022
adrianpk pushed a commit to foorester/oapi-codegen that referenced this pull request Jan 16, 2024
Co-authored-by: Marcin Romaszewicz <47459980+deepmap-marcinr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants