Add pyproject.toml #378
Draft
Add pyproject.toml #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup.py is obsolete nowadays and replaced by pyproject.toml (PEP 518).
|
I'm fine with moving to pyproject.toml, although I'm quite sure that support for setup.py will not vanish really soon. But this PR removes instructions for installation without pip from a locally downloaded package, though, if I'm not mistaken. Or am I missing something? |
|
Instead of removing the section, I should have moved the downloaded package installation from Anyway, I think there is a unrelated reportlab installation issue in the test suite, so putting this as WIP until it's fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py is obsolete nowadays and replaced by pyproject.toml (PEP 518).