-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboard-core-plugins typescript conversion #693
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
88035d6
convert to ts
Zhou-Ziheng 2ef053f
convert js to ts in styleguide
Zhou-Ziheng fd9ab19
added requested changes
Zhou-Ziheng 6fa849c
finished fixing requested changes
Zhou-Ziheng 2d02906
fixed merge conflicts
Zhou-Ziheng 68ae4d4
fixed meerge errors
Zhou-Ziheng df7466b
Minor UX fixes to go to row
dsmmcken 2e56756
self-review
dsmmcken 4778da9
Merge remote-tracking branch 'origin/main'
Zhou-Ziheng d836ebd
WIP plugins conversion
Zhou-Ziheng f34ec25
Merge remote-tracking branch 'origin/main' into 579-plugins-ts
Zhou-Ziheng 23d4334
WIP
Zhou-Ziheng 0159ade
WIP
Zhou-Ziheng 63bd1f5
wip
Zhou-Ziheng a1e3d0a
Merge remote-tracking branch 'origin/main' into 579-plugins-ts
Zhou-Ziheng a2d5c83
second last chunk
Zhou-Ziheng 99be5d1
final chunk - errors
Zhou-Ziheng f2e3250
WIP
Zhou-Ziheng c7bb2b2
WIP
Zhou-Ziheng 6e46614
wip
Zhou-Ziheng 5e62263
chart
Zhou-Ziheng 33b9895
final chunk plugins conversio
Zhou-Ziheng 02e1cb1
fixed requested changes
Zhou-Ziheng c0b115d
Merge remote-tracking branch 'origin/main' into 579-plugins-ts
Zhou-Ziheng e0c51bf
fixed requested changes
Zhou-Ziheng dee6609
requested changes and test file conversion
Zhou-Ziheng 3d131a0
asdf
Zhou-Ziheng f594ae8
unsaved file
Zhou-Ziheng ee248c3
fixed import errors
Zhou-Ziheng 9a2554f
improved type sfor Linker
Zhou-Ziheng 8deef88
final change?
Zhou-Ziheng File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
5 changes: 2 additions & 3 deletions
5
packages/dashboard-core-plugins/src/linker/ColumnSelectionValidator.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,7 @@ | ||
import { PanelComponent } from '@deephaven/dashboard'; | ||
|
||
export type LinkColumnSelection = { name: string; type?: string }; | ||
import { LinkColumn } from './LinkerUtils'; | ||
|
||
export type ColumnSelectionValidator = ( | ||
panel: PanelComponent, | ||
tableColumn?: LinkColumnSelection | ||
tableColumn?: LinkColumn | ||
) => boolean; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsetFilterValue
should just allow null columnType instead. By checking fornull
here you're changing one of the code paths.