Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package.json with file: links #501

Merged
merged 1 commit into from Mar 28, 2022
Merged

Update package.json with file: links #501

merged 1 commit into from Mar 28, 2022

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Mar 28, 2022

  • Reference the packages directly using file: links
  • Update peer deps to new package versions. We're still in 0.x so every bump is a breaking change, we should consider moving to 1.x
  • Ensured npm install works correctly after running npm run clean
  • Started a separate branch and ensured a version bump would work correctly with an install

Fixes #500

@mofojed
Update package.json with file: links
4ef0f82 
- Reference the packages directly using file: links
- Update peer deps to new package versions. We're still in 0.x so every bump is a breaking change, we should consider moving to 1.x
@mofojed mofojed added this to the March 2022 milestone Mar 28, 2022
@mofojed mofojed requested a review from vbabich March 28, 2022 15:27
@mofojed mofojed self-assigned this Mar 28, 2022
@mofojed mofojed merged commit 7cd1bed into deephaven:main Mar 28, 2022
@mofojed mofojed deleted the fix-lerna branch March 28, 2022 19:47
@mofojed mofojed mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbabich vbabich vbabich approved these changes

Assignees

@mofojed mofojed

Labels
internal
Projects
None yet
Milestone
March 2022
Development

Successfully merging this pull request may close these issues.

Version bump causes issues after updating to npm8 workspaces
2 participants
@mofojed @vbabich