Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Examples to Always Display UtteranceEnd Even If Not Using to Process Transcription #386

Merged

Conversation

dvonthenen
Copy link
Contributor

@dvonthenen dvonthenen commented May 8, 2024

Proposed changes

To some it isn't clear the event is being fired. This displays receiving the event even if it doesn't contribute to the transcription processing.

Syntac updates for Black Formatter (would be good to have that automation in place right?)

Removed "Deepgram " from each event name. Doesn't add value. Of course it's Deepgram, what else would it be?

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

NA

@dvonthenen dvonthenen force-pushed the update-example-always-utterance branch from 2f4c02b to 3a29e00 Compare May 8, 2024 14:17
@dvonthenen dvonthenen merged commit 83d5f03 into deepgram:main May 13, 2024
1 check passed
@dvonthenen dvonthenen deleted the update-example-always-utterance branch May 13, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants