Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Set Thread References to None #372

Merged
merged 1 commit into from Apr 24, 2024

Conversation

dvonthenen
Copy link
Contributor

@dvonthenen dvonthenen commented Apr 22, 2024

Proposed changes

Addresses issue: #370

I believe this is similar to this issue fixed in PR #366. The threads should have already exited (because of the join and gather) but in the event that hasn't happened yet, this keeps the thread references around until a reconnect has happened (ie they will be replaced with new thread references).

Also, found in testing an additional place where an exception can be thrown on a successful exit.

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Tested AsyncLive and Live Clients for all examples.

@dvonthenen dvonthenen merged commit b52c70d into deepgram:main Apr 24, 2024
1 check passed
@dvonthenen dvonthenen deleted the dont-set-obj-threads-to-none branch April 24, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants