Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NoneType exit event #365

Merged
merged 2 commits into from Apr 16, 2024

Conversation

jkroll-deepgram
Copy link
Contributor

Proposed changes

Fix a bug where is_set() is being called on self._exit_event when it has a value of None, causing an AttributeError that bubbles up as an error in application code. To fix, require that self._exit_event is not None before calling self._exit_event.is_set().

I do also see in other spots that events are being initialized as asyncio.Event(). Should the exit event be instantiated as self._exit_event = asyncio.Event() instead of self._exit_event = None, so self._exit_event is never None in the first place?

Types of changes

What types of changes does your code introduce to the community Python SDK?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update or tests (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have lint'ed all of my code using repo standards
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@dvonthenen dvonthenen merged commit 7461d02 into deepgram:main Apr 16, 2024
1 check passed
@dvonthenen
Copy link
Contributor

I do also see in other spots that events are being initialized as asyncio.Event(). Should the exit event be instantiated as self._exit_event = asyncio.Event() instead of self._exit_event = None, so self._exit_event is never None in the first place?

I can take a look at this and double check.

@dvonthenen
Copy link
Contributor

I suspect that the event should have been reset and not deleted is the problem. This might have been a copy and paste gone too far. Confirming this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants