mm: light refactoring. more logging #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonp
reviewed
May 18, 2024
Comment on lines
+389
to
+391
| if err := f(); err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
If the update function fails, this will be in a weird state, because the waitgroup returned from Connect will still not be done. The only way to get the bot to run again is to do another update. You won't be able to start it. I think resuming with the old config would be fine, and if the restart fails, then kill the unifiedExchangeAdaptor.
There was a problem hiding this comment.
I opted to just shut the whole thing down if there is an error updating config.
client/mm/mm_basic.go
Outdated
| // Process book updates | ||
| wg.Add(1) | ||
| m.wg.Add(1) |
There was a problem hiding this comment.
Since the bots are using the waitgroup of the exchange adaptor, the Disconnect call in withPause never returns.
JoeGruffins
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unifiedExchangeAdaptor, which reduces duplication and enables sharing of utilities and more concise access to immutable properties.unifiedExchangeAdaptor