-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fee info and best unit functions #2762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm running this PR but can't see the fee box. Do you know if there is a setting I need?
It's only displayed if you have both fiat exchange rate and a fee rate from the wallet. If you're on an SPV wallet, you must have external rates allowed (probably all utxo wallets on simnet, actually). You also must have fiat exchange rates on. All of these should be on by default now, but if you're not starting with a fresh wallet, they might not be. |
I'm running testnet and all these settings are on 🥲 but it's still not showing up. |
I'll hit you on Matrix |
I had a couple of bugs with the hovering selection menu. Should be fixed now. Also have fixed a wallet configuration bug that was preventing external fiat rates from being turned on for wallets created in the quick setup form. Made external rate fallback default true for all assets. |
Testing well for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but still not able to view the fee box for btc
and bch
.
I see the fee boxes. @ukane-philemon are you sure your site files are on the right commit? There's a Build ID at the bottom of the Settings menu you can check to make sure: |
@buck54321 can we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just don't see the fees displayed for DCR. Maybe a UI issue since DCR has additional panels there?
We can't do it at an error because it's not necessarily an error. For an spv wallet or an rpc wallet without a primed |
Add algorithm to select best of conventional or atomic unit. Add standardized element set for value with unit or rate with unit. Add hover menu allowing user to select alternative units.
Adds a dialog to display fee information for a blockchain.
Adds
Doc
methods for selecting the most appropriate unit for a value. Adds a standardized element set that allows quickly setting values with units or rates with units. Adds hover menu to allow user to select different units for a displayed value. Populates alternative units in variousUnitInfo
.