eth: refactor tx montoring, handle tx resubmissions better, general refactoring #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not ready for testing quite yet. |
|
It's ready again. |
buck54321
force-pushed
the
ethrefactor
branch
3 times, most recently
from
d6973fa
to
7b8ba91
Compare
JoeGruffins
approved these changes
May 9, 2024
martonp
reviewed
May 11, 2024
client/core/trade.go
Outdated
Comment on lines
3022
to
3028
| case errors.Is(err, asset.ErrTxLost): | ||
| // The transaction was nonce-replaced or otherwise lost without | ||
| // rejection or with user acknowlegement. Try again if we're the taker. | ||
| // If we're the maker we'll give up and try to refund. | ||
| c.log.Infof("Redemption %s (%s) has been noted as lost.", match.MetaData.Proof.TakerRedeem, unbip(toWallet.AssetID)) | ||
| if match.Side == order.Taker { | ||
| match.MetaData.Proof.TakerRedeem = nil | ||
| match.Status = order.MakerRedeemed | ||
| } |
There was a problem hiding this comment.
In this case the counterparty of the maker could have also got the secret. You didn't set match.MetaData.Proof.SelfRevoked = true over there though.. so will it refund?
There was a problem hiding this comment.
I've added commented tests for all actions now.
martonp
reviewed
May 19, 2024
martonp
reviewed
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work accomplishes a number of goals required for putting eth and polygon into production.
Hand-tested. Will do some self-review asap.