mm: Individually Start Bots / Live Updates #2738
Conversation
| t.Helper() | ||
| var err error | ||
| for i := 0; i < 20; i++ { | ||
| time.Sleep(100 * time.Millisecond) |
There was a problem hiding this comment.
I know it's not new, but what are we synchronizing here?
There was a problem hiding this comment.
storeEvent is async.
client/mm/exchange_adaptor.go
Outdated
| // placementIndex/counterTradeRate are used by MultiTrade to know | ||
| // which orders to place/cancel. | ||
| placementIndex uint64 | ||
| counterTradeRate uint64 | ||
| } | ||
|
|
||
| // updateState should only be called with txMtx write locked. |
There was a problem hiding this comment.
Is your mutex comment outdated?
client/mm/exchange_adaptor.go
Outdated
| } | ||
|
|
||
| func (u *unifiedExchangeAdaptor) updateConfig(cfg *BotConfig, balanceDiffs *BotBalanceDiffs) { | ||
| cfgUpdated := !reflect.DeepEqual(cfg, u.botCfg.Load().(*BotConfig)) |
There was a problem hiding this comment.
No DeepEqual in production please. Why are we grouping config and inventory updates. They seem like separate events.
There was a problem hiding this comment.
What are you thinking for the UI? I was thinking that when you update the config, you would also have the option to update balance in the same operation. Then there would also be a separate screen for just updating balances. I could add a separate function only for balance updates.
client/mm/mm.go
Outdated
| ctx, die := context.WithCancel(m.ctx) | ||
| adaptorUpdateManager, botUpdateManager := cfgUpdateManagerPair() | ||
| mktID := dexMarketID(botCfg.Host, botCfg.BaseID, botCfg.QuoteID) | ||
| logger := m.botSubLogger(botCfg) | ||
| exchangeAdaptor := unifiedExchangeAdaptorForBot(&exchangeAdaptorCfg{ | ||
| botID: mktID, | ||
| market: mkt, | ||
| baseDexBalances: allocation.DEX, | ||
| baseCexBalances: allocation.CEX, | ||
| core: m.core, | ||
| cex: cex, | ||
| log: logger, | ||
| botCfg: botCfg, | ||
| eventLogDB: m.eventLogDB, | ||
| cfgUpdateManager: adaptorUpdateManager, | ||
| }) | ||
| if err := exchangeAdaptor.run(ctx); err != nil { | ||
| die() | ||
| return err | ||
| } |
There was a problem hiding this comment.
This context pattern is what we have dex.ConnectionMaster for.
client/mm/mm_arb_market_maker.go
Outdated
| pauseEpochs <- struct{}{} | ||
| pauseCEXUpdates <- struct{}{} | ||
| pauseDEXUpdates <- struct{}{} | ||
| updateManager.botPaused <- struct{}{} |
There was a problem hiding this comment.
This seems racy. These are zero-capacity channels. If the context is canceled after the updateBot message but before one of these structs{}{} can be received, e.g. while processDEXOrderUpdate is running, this will deadlock.
There was a problem hiding this comment.
It's purposely zero-capacity because I wanted it to block, but I see your point about the context getting cancelled.
client/mm/price_oracle.go
Outdated
| func coinpapSlug(symbol, name string) string { | ||
| slug := fmt.Sprintf("%s-%s", symbol, name) | ||
| // Special handling for asset names with multiple space, e.g Bitcoin Cash. | ||
| return strings.ToLower(strings.ReplaceAll(slug, " ", "-")) | ||
| } | ||
|
|
martonp
force-pushed
the
mmUpdateConfig
branch
2 times, most recently
from
7204b9d
to
787758e
Compare
There was a problem hiding this comment.
@martonp please accept these changes to create a transitional API and UI. The front end still looks the same an all bots are still started and stopped together. I'll have lots of followup to adapt the UI and other stuff.
buck54321/dcrdex@787758e...buck54321:dcrdex:bot-transitional
This diff adds the ability to start/stop bots individually and also to perform live updates to bot settings and the amount of funds controlled by bots. All balance fields are removed from the BotConfig. These are now specified when a bot is started. Bots and exchange adaptors are now dex.Connectors. To perform an update, the bot is first paused, the updates are made, and then the bot is resumed again. A botConnectionMaster that wraps a dex.ConnectionMaster is added to facilitate pausing and resuming of bots. To perform a balance update, we need to know the exact amount that is available in the wallets and on the CEX that is not currently reserved by a running bot. To do this, we first check the available amounts according to the wallet/cex, then we sync the state of all pending trades, deposits, and withdrawals, and then we recheck the available amounts. If the first check is the same as the last, we know nothing has changed and we have the correct amounts, so we can proceed. In order for this to work properly, the `WalletTransaction` function of wallets must return `Confirmed == true` if and only if the any incoming funds from that transaction are part of the available balance. The priceOracle is also refactored. Instead of having a “synced” priceOracle used for markets on which a bot is running, and an “unsynced” one for any other markets, there is now only one priceOracle. `startAutoSyncingMarket` and `stopAutoSyncingMarket` are called whenever bots are started / stopped. A testing program is added that tracks the available balances in wallets/cexes that are unused by any bots. This amount should not change unless the user start, stops, or updates a bot. If there are any unexpected changes, this means there is a bug in the balance tracking.
This diff adds the ability to start/stop bots individually and also to perform live updates to bot settings and the amount of funds controlled by bots.
All balance fields are removed from the BotConfig. These are now specified when a bot is started.
Bots and exchange adaptors are now
dex.Connectors. To perform an update, the bot is first paused, the updates are made, and then the bot is resumed again. AbotConnectionMasterthat wraps adex.ConnectionMasteris added to facilitate pausing and resuming of bots.To perform a balance update, we need to know the exact amount that is available in the wallets and on the CEX that is not currently reserved by a running bot. To do this, we first check the available amounts according to the wallet/cex, then we sync the state of all pending trades, deposits, and withdrawals, and then we recheck the available amounts. If the first check is the same as the last, we know nothing has changed and we have the correct amounts, so we can proceed. In order for this to work properly, the
WalletTransactionfunction of wallets must returnConfirmed == trueif and only if the any incoming funds from that transaction are part of the available balance.The priceOracle is also refactored. Instead of having a “synced” priceOracle used for markets on which a bot is running, and an “unsynced” one for any other markets, there is now only one priceOracle.
startAutoSyncingMarketandstopAutoSyncingMarketare called whenever bots are started / stopped.A testing program is added that tracks the available balances in wallets/cexes that are unused by any bots. This amount should not change unless the user start, stops, or updates a bot. If there are any unexpected changes, this means there is a bug in the balance tracking.