zec: finish shielded-by-default and remove ShieldedWallet #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
changed the title
buck54321
force-pushed
the
shielded-by-default
branch
from
60fc6a8
to
b0a2627
Compare
JoeGruffins
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Are you using the latest zcash? I'm on v5.8.0 and loadbot cannot get an address:
$ ./alpha getnewaddress
error code: -1
error message:
getnewaddress is DEPRECATED and will be removed in a future release
Use z_getnewaccount and z_getaddressforaccount instead, or restart
with `-allowdeprecated=getnewaddress` if you require backward compatibility.
See https://zcash.github.io/zcash/user/deprecation.html for more information.
The dexcctl script will error with this on alpha wallet, but looks fine on beta, can you change it to beta?
configuring Zcash wallet
error creating zec wallet: failed to connect zec wallet: ConnectOnce error: connect failure: there appears to be some transparent balance that is not in the zeroth account. To operate correctly, all balance must be in the zeroth account. Move all balance to the zeroth account to use the Zcash wallet
Tested a few trades on testnet as well and was fine.
|
I'm sure unrelated to these changes, but posting anyhow. Clicking on the Balance amount here is not putting the full amount in the field. It says Nan.
|
buck54321
force-pushed
the
shielded-by-default
branch
from
b0a2627
to
984ce17
Compare
buck54321
force-pushed
the
shielded-by-default
branch
from
984ce17
to
1a269be
Compare
buck54321
force-pushed
the
shielded-by-default
branch
from
1a269be
to
d4f4693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.