Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btc: update btcd to fix critical block parsing failure #1896

Merged
merged 1 commit into from Oct 10, 2022

Commits on Oct 10, 2022

  1. btc: update btcd to fix critical block parsing failure

    This updates the btcd require to v0.23.2, which includes a critical fix
    to the wire package's block parsing code that resolves a failure to
    deserialize a block with a script witness item larger than 11000.
    
    There are now blocks on mainnet and testnet that cannot be deserialized
    with v0.23.1, meaning this is a critical fix for takers who need to
    find the maker's redeem transaction and pull the block containing the
    spending transaction. For SPV, only the matching block is pulled.
    For a full node RPC wallet, the blocks are pulled in sequence and each
    transaction is checked directly. As such, the issue affects both types
    of wallet clients.
    
    See mainnet block 0000000000000000000400a35a007e223a7fb8a622dc7b5aa5eaace6824291fb
    containing and enormous 998-of-999 tapscript multisig in txn
    7393096d97bfee8660f4100ffd61874d62f9a65de9fb6acf740c4c386990ef73.
    
    See also testnet block 0000000000000032fcf519b61aad2b966348e3f2d27687b26277933cc9881965
    containing taproot transaction
    44692bc2da73192cd0b89bc7a43c0ce43578f6b3567bc945e46e6952e8ec5ca5.
    
    This also updates the btcwallet require from 0.15.1 to 0.16.1.
    
    This also adds a new test with the above mainnet block and transaction
    as test vectors.
    chappjc committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    c6b6c3a View commit details
    Browse the repository at this point in the history