Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[istio] Add globalVersion and additionalVersions mc options validations #8404

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

tarabrind
Copy link
Contributor

@tarabrind tarabrind commented May 16, 2024

Description

Add the globalVersion and additionalVersions ModuleConfig options validations.

Why do we need it, and what problem does it solve?

It's easy to make a mistake in ModuleConfig, and it's hard to figure out if there is a problem.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: istio
type:  chore
summary: Added the globalVersion and additionalVersions ModuleConfig options validations.
impact_level: default

@github-actions github-actions bot added area/network Pull requests that update cni and network modules area/api-change Pull requests that api changing labels May 16, 2024
@tarabrind tarabrind added this to the v1.61.0 milestone May 16, 2024
Signed-off-by: TDen <tdencrash@gmail.com>
Signed-off-by: TDen <tdencrash@gmail.com>
@tarabrind tarabrind force-pushed the istio-global-version-validation branch from eb4a00c to 7ba0dde Compare May 17, 2024 13:33
Signed-off-by: TDen <tdencrash@gmail.com>
@tarabrind tarabrind changed the title [istio] Add the globalVersion mc option validation [istio] Add the globalVersion and additionalVersions mc options validations May 18, 2024
@tarabrind tarabrind changed the title [istio] Add the globalVersion and additionalVersions mc options validations [istio] Add globalVersion and additionalVersions mc options validations May 18, 2024
@z9r5 z9r5 requested a review from apolovov May 20, 2024 02:50
@z9r5 z9r5 added the skip/documentation-validation Skip documentation validation in pull request label May 20, 2024
Signed-off-by: TDen <tdencrash@gmail.com>
@apolovov apolovov marked this pull request as ready for review May 22, 2024 07:59
@z9r5 z9r5 added the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jun 3, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 3, 2024

🔴 e2e: Yandex.Cloud for deckhouse:istio-global-version-validation failed in 12m40s.

E2e for yandex-cloud WithoutNAT;containerd;1.25 was failed. Use:
ssh -i ~/.ssh/e2e-id-rsa redos@158.160.54.175 - connect for debugging;

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.25 9345185739 9345185739-1-con-1-25 /sys/deckhouse-oss/install:pr8404 redos@158.160.54.175 - for abort failed cluster

Workflow details (1 job failed)

Yandex.Cloud-WithoutNAT-Containerd-1.25 - Connection string: ssh redos@158.160.54.175

🔴 e2e: Yandex.Cloud, Containerd, Kubernetes 1.25 failed in 12m0s.

@github-actions github-actions bot removed the e2e/run/yandex-cloud Run e2e tests in Yandex Cloud label Jun 3, 2024
@deckhouse-BOaTswain deckhouse-BOaTswain added the e2e/cluster/failed Pull request contains failed e2e cluster label Jun 3, 2024
@z9r5
Copy link
Member

z9r5 commented Jun 3, 2024

/e2e/abort yandex-cloud;WithoutNAT;containerd;1.25 9345185739 9345185739-1-con-1-25 /sys/deckhouse-oss/install:pr8404 redos@158.160.54.175

@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 3, 2024

🟢 destroy cluster: Yandex.Cloud for refs/heads/main succeeded in 18m37s.

Workflow details

🟢 destroy cluster: Yandex.Cloud, Containerd, Kubernetes 1.25 succeeded in 18m12s.

@z9r5 z9r5 removed the e2e/cluster/failed Pull request contains failed e2e cluster label Jun 3, 2024
@z9r5 z9r5 merged commit 1d04014 into main Jun 3, 2024
48 of 49 checks passed
@z9r5 z9r5 deleted the istio-global-version-validation branch June 3, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-change Pull requests that api changing area/network Pull requests that update cni and network modules skip/documentation-validation Skip documentation validation in pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants