Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[static-routing-manager] Add new module static-routing-manager #7952

Open
wants to merge 94 commits into
base: main
Choose a base branch
from
Open

[static-routing-manager] Add new module static-routing-manager #7952

wants to merge 94 commits into from

Conversation

AndreyPavlovFlant
Copy link
Member

@AndreyPavlovFlant AndreyPavlovFlant commented Mar 29, 2024 •
edited

Description

Adding a new module static-routing-manager.

It implements the ability to manage static routes and ip rules on cluster nodes in k8s-style via yaml declarations.

It includes:

  • k8s resources: IPRuleSet and RoutingTable.
  • Agents running on each node, tracking CR and bringing routes and rules to the desired form
  • A small orchestration performed through the module hooks

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: staticRoutingManager
type: feature
summary: Adding a new module static-routing-manager.
impact_level: default

@AndreyPavlovFlant AndreyPavlovFlant added the area/network Pull requests that update cni and network modules label Mar 29, 2024
@AndreyPavlovFlant AndreyPavlovFlant added this to the v1.60.0 milestone Mar 29, 2024
@AndreyPavlovFlant AndreyPavlovFlant self-assigned this Mar 29, 2024
@github-actions github-actions bot added area/testing Pull requests that update testing code area/docs Pull requests that update doumentation area/cluster-and-infrastructure Pull requests that update infra modules area/core Pull requests that update core modules go Pull requests that update Go code area/api-change Pull requests that api changing type/dependencies Pull requests that update a dependency file and removed area/network Pull requests that update cni and network modules labels Mar 29, 2024
@AndreyPavlovFlant AndreyPavlovFlant force-pushed the static-routing-manager branch 4 times, most recently from 48713d3 to afddbf1 Compare April 10, 2024 12:40
@AndreyPavlovFlant AndreyPavlovFlant force-pushed the static-routing-manager branch 4 times, most recently from 29cccbf to 7b67012 Compare May 3, 2024 09:10
apolovov
apolovov requested changes May 7, 2024
View reviewed changes
modules/025-static-routing-manager/hooks/ensure_crds.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/lib/common.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/lib/v1alpha1/v1alpha1.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/templates/user-authz-cluster-roles.yaml Show resolved Hide resolved
modules/025-static-routing-manager/templates/user-authz-cluster-roles.yaml Show resolved Hide resolved
modules/025-static-routing-manager/images/agent/pkg/controller/routes_reconciler_agent.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/images/agent/pkg/controller/routes_reconciler_agent.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/images/agent/pkg/controller/routes_reconciler_agent.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/images/agent/pkg/controller/routes_reconciler_agent.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/images/agent/pkg/controller/routes_reconciler_agent.go Outdated Show resolved Hide resolved
@AndreyPavlovFlant AndreyPavlovFlant modified the milestones: v1.60.0, v1.61.0 May 13, 2024
z9r5
z9r5 reviewed May 14, 2024
View reviewed changes
modules/025-static-routing-manager/crds/doc-ru-routingtables.yaml Outdated Show resolved Hide resolved
modules/025-static-routing-manager/crds/doc-ru-routingtables.yaml Outdated Show resolved Hide resolved
modules/025-static-routing-manager/crds/internal/doc-ru-noderoutingtables.yaml Outdated Show resolved Hide resolved
modules/025-static-routing-manager/crds/internal/doc-ru-noderoutingtables.yaml Outdated Show resolved Hide resolved
modules/025-static-routing-manager/crds/internal/doc-ru-noderoutingtables.yaml Outdated Show resolved Hide resolved
modules/025-static-routing-manager/crds/internal/noderoutingtables.yaml Outdated Show resolved Hide resolved
modules/025-static-routing-manager/crds/routingtables.yaml Outdated Show resolved Hide resolved
apolovov
apolovov requested changes May 17, 2024
View reviewed changes
modules/025-static-routing-manager/hooks/noderoutingtables_handler.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/noderoutingtables_handler.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/noderoutingtables_handler.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/noderoutingtables_handler.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/noderoutingtables_handler.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/noderoutingtables_handler.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/noderoutingtables_handler.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/noderoutingtables_handler.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/images/agent/pkg/controller/routes_reconciler_agent.go Show resolved Hide resolved
modules/025-static-routing-manager/images/agent/pkg/controller/routes_reconciler_agent.go Outdated Show resolved Hide resolved
@AndreyPavlovFlant AndreyPavlovFlant force-pushed the static-routing-manager branch 3 times, most recently from 2cc708f to 91ce10c Compare May 22, 2024 15:59
apolovov
apolovov requested changes Jun 4, 2024
View reviewed changes
modules/025-static-routing-manager/crds/doc-ru-iprulesets.yaml Outdated Show resolved Hide resolved
modules/025-static-routing-manager/crds/doc-ru-iprulesets.yaml Outdated Show resolved Hide resolved
modules/025-static-routing-manager/crds/iprulesets.yaml Outdated Show resolved Hide resolved
modules/025-static-routing-manager/docs/EXAMPLES.md Outdated Show resolved Hide resolved
modules/025-static-routing-manager/docs/EXAMPLES_RU.md Outdated Show resolved Hide resolved
modules/025-static-routing-manager/docs/EXAMPLES_RU.md Outdated Show resolved Hide resolved
modules/025-static-routing-manager/hooks/iprulesets_handler.go Outdated Show resolved Hide resolved
modules/025-static-routing-manager/templates/node-iprule-sets/nodeiprulesets.yaml Show resolved Hide resolved
@apolovov
Apply suggestions from code review
514ecc7 
Signed-off-by: Andrey Polovov <andrey.polovov@flant.com>
@AndreyPavlovFlant AndreyPavlovFlant changed the title [static-routing-manager] Add new module [static-routing-manager] Add new module static-routing-manager Jun 5, 2024
@AndreyPavlovFlant
return required: [start] in crds
1e9f363 
Signed-off-by: Andrey Pavlov <andrey.pavlov@flant.com>
@AndreyPavlovFlant
no node
6b1943b 
Signed-off-by: Andrey Pavlov <andrey.pavlov@flant.com>
@apolovov apolovov marked this pull request as ready for review June 5, 2024 13:43
@apolovov apolovov modified the milestones: v1.62.0, v1.61.1 Jun 5, 2024
@AndreyPavlovFlant AndreyPavlovFlant added skip/documentation-validation Skip documentation validation in pull request e2e/use/k8s/1.26 Use Kubernetes 1.26 for e2e tests e2e/use/k8s/1.27 Use Kubernetes 1.27 for e2e tests e2e/use/k8s/1.28 Use Kubernetes 1.28 for e2e tests e2e/use/k8s/1.29 Use Kubernetes 1.29 for e2e tests e2e/run/aws Run e2e tests in AWS and removed e2e/use/k8s/1.26 Use Kubernetes 1.26 for e2e tests e2e/use/k8s/1.28 Use Kubernetes 1.28 for e2e tests e2e/use/k8s/1.29 Use Kubernetes 1.29 for e2e tests labels Jun 5, 2024
@deckhouse-BOaTswain
Copy link
Collaborator

deckhouse-BOaTswain commented Jun 5, 2024 •
edited

🟢 e2e: AWS for deckhouse:static-routing-manager succeeded in 35m8s.

Workflow details

AWS-WithoutNAT-Containerd-1.27 - Connection string: ssh centos@3.75.37.167

🟢 e2e: AWS, Containerd, Kubernetes 1.27 succeeded in 34m27s.

@github-actions github-actions bot removed the e2e/run/aws Run e2e tests in AWS label Jun 5, 2024
@AndreyPavlovFlant AndreyPavlovFlant added the area/network Pull requests that update cni and network modules label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apolovov apolovov apolovov approved these changes

@nabokihms nabokihms Awaiting requested review from nabokihms nabokihms is a code owner

@konstantin-axenov konstantin-axenov Awaiting requested review from konstantin-axenov konstantin-axenov is a code owner

@yalosev yalosev Awaiting requested review from yalosev yalosev is a code owner

@miklezzzz miklezzzz Awaiting requested review from miklezzzz miklezzzz is a code owner

@RomanenkoDenys RomanenkoDenys Awaiting requested review from RomanenkoDenys RomanenkoDenys is a code owner

@name212 name212 Awaiting requested review from name212 name212 is a code owner

@z9r5 z9r5 Awaiting requested review from z9r5 z9r5 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@AndreyPavlovFlant AndreyPavlovFlant

Labels
area/api-change Pull requests that api changing area/cluster-and-infrastructure Pull requests that update infra modules area/core Pull requests that update core modules area/docs Pull requests that update doumentation area/network Pull requests that update cni and network modules area/testing Pull requests that update testing code e2e/use/k8s/1.27 Use Kubernetes 1.27 for e2e tests go Pull requests that update Go code skip/documentation-validation Skip documentation validation in pull request type/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v1.61.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndreyPavlovFlant @deckhouse-BOaTswain @z9r5 @apolovov