[deckhouse-controller] Fix auth data handling in change-registry helper #7095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/core
mvasl
force-pushed
the
fix/registry-change-auth-data
branch
2 times, most recently
from
4db6f9e
to
c5db697
Compare
github-actions
bot
removed
the
e2e/run/yandex-cloud
yalosev
requested changes
Jan 12, 2024
|
Filed a bug to the go-containerregistry team about problems with their JSON marshalling implementation for Until it's fixed we can use this PR as a workaround. @yalosev cc |
Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
mvasl
force-pushed
the
fix/registry-change-auth-data
branch
from
c5db697
to
276c99a
Compare
|
🟢 Workflow detailsYandex.Cloud-WithoutNAT-Containerd-1.25 - Connection string: 🟢 |
github-actions
bot
removed
the
e2e/run/yandex-cloud
yalosev
approved these changes
Jan 16, 2024
name212
approved these changes
Jan 17, 2024
Merged
|
Backport failed. See Job for details. |
ghostinsoba
pushed a commit
that referenced
this pull request
Jan 31, 2024
…er (#7095) Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com> Co-authored-by: Maxim Vasilenko <maksim.vasilenko@flant.com> Signed-off-by: Timur Kamaev <timur.kamaev@flant.com>
pashcovich
pushed a commit
that referenced
this pull request
Mar 6, 2024
…er (#7095) Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com> Co-authored-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
Horiodino
pushed a commit
to Horiodino/deckhouse
that referenced
this pull request
Apr 21, 2024
…er (deckhouse#7095) Signed-off-by: Maxim Vasilenko <maksim.vasilenko@flant.com> Co-authored-by: Maxim Vasilenko <maksim.vasilenko@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug where helper would not properly marshal provided credentials for registry into the secret. Unit tests of
deckhouse-controllerare now enabled as part of CI pipeline.Why do we need it, and what problem does it solve?
This fixes a reported bug introduced with a
go-containerregistryupdate.Why do we need it in the patch release (if we do)?
Checklist
Changelog entries