Point simplecov to master to fix a coverage on monorepos

[andreslucena]

🎩 What? Why?

This one is 100% from @mrcasals - I'm only making the final (momentary) fix:

When developing #5934, we found a problem: when running tests for the decidim-proposals engine, where we know code from decidim-core is executed, the code in decidim-core was not considered as covered. This reduced the % of covered code in the results. This was reported in simplecov-ruby/simplecov#885.

The Simplecov maintainers have worked on this issue and have released a PR that should fix the problem: simplecov-ruby/simplecov#894. We should try this in our repo and see if it actually fixed it.

So, basically, this should fix the coverage issues that we have 🙏 🙏

As stated on the comment on the Gemfile, on a next simplecov version (0.18.6 or 0.19.0) this will not be necessary and can be removed.

📌 Related Issues

• Fixes Use latest simplecov for better coverage results #6230

[mrcasals]

@andreslucena you'll need to run bin/rake bundle to fix the tests!

[mrcasals]

Looks good to me! We got a 4.72% coverage increase!

[mrcasals]

@decidim/core can you review this, please? 😄

[deivid-rodriguez]

Hi 👋! I'm glad cherry-picking this fix did the trick! 🎉

Note that the coverage increase should've been actually higher but for some reason (not sure if it's know/unknown, permament/intermittent), some files that were previously covered are now uncovered.

I believe this might be an issue with the codecov uploader since for example with decidim-debates, one of the modules suffering from this coverage decrease, the upload seems to be failing.

    -> Found 2 reports
==> Detecting git/mercurial file structure
==> Reading reports
    + ./coverage/coverage.xml bytes=4161299
    + ./spec/coverage/coverage.xml bytes=11878
==> Appending adjustments
    https://docs.codecov.io/docs/fixing-reports
/dev/fd/63: line 1574: echo: write error: Broken pipe
    + Found adjustments
==> Gzipping contents
==> Uploading reports
    url: https://codecov.io
    query: branch=chore%2Fci%2Fsimplecov-master&commit=3a00ae1654f28eaa8d5ed57851ebd35a4545c74a&build=148713119&build_url=http%3A%2F%2Fgithub.com%2Fdecidim%2Fdecidim%2Factions%2Fruns%2F148713119&name=decidim-debates&tag=&slug=decidim%2Fdecidim&service=github-actions&flags=&pr=6240&job=
->  Pinging Codecov
https://codecov.io/upload/v4?package=bash-20200622-40cebbd&token=secret&branch=chore%2Fci%2Fsimplecov-master&commit=3a00ae1654f28eaa8d5ed57851ebd35a4545c74a&build=148713119&build_url=http%3A%2F%2Fgithub.com%2Fdecidim%2Fdecidim%2Factions%2Fruns%2F148713119&name=decidim-debates&tag=&slug=decidim%2Fdecidim&service=github-actions&flags=&pr=6240&job=
->  Uploading to

curl: (3) <url> malformed
curl: (3) <url> malformed
    X> Failed to upload
    -> Sleeping for 30s and trying again...
/dev/fd/63: line 1668: [: 0+1: integer expression expected
    -> Uploading to Codecov
    -> Sleeping for 30s and trying again...
/dev/fd/63: line 1712: [: 0+1: integer expression expected
    X> Failed to upload coverage reports
See for example the errors while uploading

[mrcasals]

Hi @deivid-rodriguez! Thanks for stopping by! I didn't check the actual report, thanks for noticing. This is something we've been encountering since we moved to Codecov (Codeclimate had limitations when moving the test suite to GitHub Actions).

@decidim/core maybe we can try to use what we did for #5995 for the uploads?

[deivid-rodriguez]

No problem @mrcasals! Keeping letting us know if simplecov gives strange results again 👍.

[tramuntanal]

Hi @deivid-rodriguez thanks for commenting on it 😄

@mrcasals As I can see in the log there's a strange /dev/fd/63: line 1574: echo: write error: Broken pipe so it will be a good to add a retry to see if this broken pipes are random and punctual or related with something in the PRs. I'll try to have it for this week

[deivid-rodriguez]

No worries @tramuntanal 😃

From what I could see the codecov github action is essentially downloading a script, setting some environment variables, and running the script. What I would do if I had to debug this would be to run that manually instead of using the action so that I can at least set -x and see what's going on.

Anyways, good luck! :)

[deivid-rodriguez]

Simplecov 0.19.0 is out, in case you want to go back to using a released version :)

[tramuntanal]

thanks for advising @deivid-rodriguez we did the update 👍 !