Thread-safe locale switching #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mrcasals
reviewed
Oct 5, 2018
| locale = if params["locale"] | ||
| params["locale"] | ||
| elsif current_user && current_user.locale.present? | ||
| current_user.locale | ||
| end | ||
|
|
||
| I18n.locale = available_locales.include?(locale) ? locale : default_locale | ||
| I18n.with_locale(available_locales.include?(locale) ? locale : default_locale, &action) |
There was a problem hiding this comment.
In case someone checks this code and wonders (like me) where are we changing the user locale, we currently do this here:
mrcasals
previously approved these changes
Oct 5, 2018
|
I don't think this requires a Changelog entry. @deivid-rodriguez is this ready for merge? 馃槃 |
|
Actually I wrote a changelog entry, but forgot to push it! Since this might fix a real end user problem, I think a changelog entry is good! |
deivid-rodriguez
force-pushed
the
thread_safe_locale_switching
branch
from
06033a2
to
2f0b0db
Compare
mrcasals
approved these changes
Oct 5, 2018
|
Cool, thanks! Merging this! 馃槃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Decidim is not changing locales in a thread-safe manner, as explained in this rails issue. So after one request changes the locale, another request could accidentally use the changed value.
馃搶 Related Issues
馃搵 Subtasks
CHANGELOGentry馃摲 Screenshots (optional)
None.