Implement review recommendations

decidim · Dec 14, 2021 · 325509d · 325509d
1 parent 1168871
commit 325509d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/decidim-dev/decidim-dev.gemspec b/decidim-dev/decidim-dev.gemspec
@@ -44,7 +44,6 @@ Gem::Specification.new do |s|
   s.add_dependency "selenium-webdriver", "~> 3.142"
   s.add_dependency "simplecov", "~> 0.19.0"
   s.add_dependency "simplecov-cobertura", "~> 1.3.1"
-  # s.add_dependency "system_test_html_screenshots", "~> 0.2"
   s.add_dependency "w3c_rspec_validators", "~> 0.3.0"
   s.add_dependency "webmock", "~> 3.6"
   s.add_dependency "wisper-rspec", "~> 1.0"

diff --git a/decidim-dev/lib/decidim/dev/test/rspec_support/screenshot_helper.rb b/decidim-dev/lib/decidim/dev/test/rspec_support/screenshot_helper.rb
@@ -1,5 +1,10 @@
 # frozen_string_literal: true
 
+#
+# Copyright (c) 2018 David Rodríguez - The MIT License (MIT)
+# Originally copied from https://gitlab.com/deivid-rodriguez/system_test_html_screenshots
+#
+
 require "action_dispatch/system_testing/test_helpers/screenshot_helper"
 
 module ActionDispatch

diff --git a/decidim-dev/lib/decidim/dev/test/spec_helper.rb b/decidim-dev/lib/decidim/dev/test/spec_helper.rb
@@ -26,7 +26,6 @@
   config.order = :random
   config.raise_errors_for_deprecations!
   config.example_status_persistence_file_path = ".rspec-failures"
-  # config.filter_run_excluding type: "controller"
 
   # If you're not using ActiveRecord, or you'd prefer not to run each of your
   # examples within a transaction, comment the following line or assign false