New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In-page search #60
Open
kordwarshuis
wants to merge
7
commits into
decentralized-identity:master
Choose a base branch
from
kordwarshuis:inpagesearch
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
In-page search #60
kordwarshuis
wants to merge
7
commits into
decentralized-identity:master
from
kordwarshuis:inpagesearch
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, could you maybe take a look at this? I made this for the Trust over IP (ToIP) organisation and Henk van Cann. Would be great if it could be integrated. |
Will pull in and test this week. |
Thanks! |
Just looked at the demo and have a bit of feedback:
|
Good suggestions, I will implement them. |
Please let me know if this is ok? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an "instant search" or "dynamic search" (results while you type). Matches are highlighted. Autoscroll to the first match.