feat: Implement _disableInitializers in constructor #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachomazzara
approved these changes
Sep 15, 2022
fzavalia
deleted the
feat/implement-disableInitializers-in-constructor
branch
fzavalia
added a commit
that referenced
this pull request
Sep 23, 2022
* feat: Store pricePerDayLength in a separate variable to reduce gas (#35) * feat: Use chained init functions of meta and nonce verifiable contracts (#34) * feat: Use chained init functions of meta and nonce verifiable contracts * chore: Update commons version * chore: Test name and version hash init * feat: Reentrancy Guard (#36) * feat: Protect functions with reentrancy guard * chore: Test Reentrancy though claim * chore: ReentrantERC721 to tests reentrancies * feat: Move nonReentrant modifiers * chore: Add nonReentrant tests * feat: New var for min max days (#42) * chore: Remove unnecessary test vars (#41) * chore: Test revert when arrays are signed in a different order that p… (#40) chore: Test revert when arrays are signed in a different order that provided * feat: Rename set operator (#37) * feat: Rename setOperator * feat: Rename event and add test * feat: Use separate nonce contracts (#38) * feat: Set many land update operator (#39) * feat: Set many land update operators * chore: Add tests * chore: Add more tests * chore: Remove only * chore: Update comment * feat: Provide multiple options to set maly land update operator * Update contracts/Rentals.sol Co-authored-by: Ignacio Mazzara <nachomazzara@gmail.com> * chore: Add test accepting empty arrays in set many land operators * feat!: Remove UpdateOperatorUpdated event * chore: Test events emited from set many land update operator * chore: Test update operator event in estate contract Co-authored-by: Ignacio Mazzara <nachomazzara@gmail.com> * feat: Claim multiple assets with a single trx (#45) * feat: Claim multiple assets with a single trx * chore: Test claiming multiple items * chore: More testtsssss * chore: Add test to check reverts when claiming invalid assets * chore: Add solhint (#44) chore: Lint * feat: Indexed events (#47) * feat: Max fee const (#48) * chore: Fix typos (#49) * feat: Optimize handle token transfer (#46) * feat: Optimize handle token transfer * chore: Rename var * feat: Set update operator of many assets (#50) * feat: Set update operator function now allows updating the operator of multiple assets * chore: Update comment * chore: Lint * chore: Text * chore: Add tests * feat: Move signature verification (#51) * feat: Move signature verification * fix: Test * feat: Allow expiration == block.timestamp (#54) * feat: Simplify ownerOf check in _rent function (#55) * chore: Test rental days overflow (#56) * chore: Test rental days overflow on acceptListing * chore: Add test for acceptOffer and onERC721Received * feat: Private state vars (#53) feat!: Make public vars private and add getters * feat: Add max rental days const (#57) * feat: Add max rental days const and verify that rental days does not exceed it on rentals * chore: Test rentals day limit on acceptListing * chore: Test in acceptOffer * chore: Test onERC721Received * chore: Add comments * chore: Fix comments * chore: Remove now useless tests * feat: Remove set token function (#58) * chore: Rename revert message (#60) * feat: Pausable (#59) * feat: Add pause functionallity * chore: Add pausable tests * feat: Remove whenNotPaused from setUpdateOperator funcs * Revert "feat: Remove whenNotPaused from setUpdateOperator funcs" This reverts commit ca28150. * chore: Various minor last minute changes (#61) * feat: Memory instead of calldata for acceptListing and acceptOffer (#62) * feat: Use memory instead of calldata * chore: Update comment * feat: Update common contracts and oz libs (#73) * feat: Remove static calls (#64) * feat: Remove owner of staticcall * feat: Remove supports interface fingerprint * feat: Remove verify fingerprint staticcall * feat: Implement _disableInitializers in constructor (#74) * feat: Use _disableInitializers in constructor * feat: Add RentalsProxy for testing purposes * feat: Add proxy in tests * chore: Automine true in afterEach * fix: Tests * chore: Add test to check that the implementation cannot be initialized * chore: Add comment * chore: Update test * feat: Update commons + Uses IndexVerifiables (#76) * feat: Update lib * feat: Rename Nonce to Index * feat: Rename signature nonces to indexes * feat: Rename accept listing index to conditionalIndex * chore: Rename variable name from test abi * chore: Comment * feat: Update commons with official version Co-authored-by: Ignacio Mazzara <nachomazzara@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #71
NOTE:
To test the _disableInitializers and keep the tests working, now the rentals contract is tested through a proxy (as it is intended to be deployed)
The RentalsProxy mock is just intended for tests and is based on https://eips.ethereum.org/EIPS/eip-1967