-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(markdown-widget): apply list item style on each block in a selection #5676
fix(markdown-widget): apply list item style on each block in a selection #5676
Conversation
Hi @erezrokah,
What files should I commit? |
Which version of |
7ae160b
to
8aafcd3
Compare
It is |
So I'm not sure. I'm using On another note, I've added two commits, one a refactoring and one a fix to set the correct list type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks 🚀 Those new tests are 💯
Thank you for all those correction. I learned a lot ✨. |
fixes #5654
Summary
When selecting multiple paragraph blocks and click List button, the current behaviour is to turn them into one list block which contains one list item, no matter how many paragraph blocks are selected.
This PR changes that behavior to make Netlify CMS editor more in line with the convention in most rich text editors. Each paragraph block in the selection will be wrapped with a respective list item. Then all the list items will be wrapped with one unifying list block.
HTML before clicking List button:
HTML after clicking List button:
Test plan
TODO:
Checklist
Please add a
x
inside each checkbox:yarn format
.yarn test
.