Upgrade ms to version 2.1.3 #819
Conversation
This comment has been minimized.
This comment has been minimized.
|
Ping @Qix- |
|
Haven't forgotten. It's just that this entire repository is blocked on Node.js breaking custom importers, which are needed for the next major release. So until that's resolved, not much will be done with |
|
@Qix- is node still breaking custom importers? |
| @@ -31,7 +31,7 @@ | |||
| "test:coverage": "cat ./coverage/lcov.info | coveralls" | |||
| }, | |||
| "dependencies": { | |||
| "ms": "2.1.2" | |||
| "ms": "2.1.3" | |||
There was a problem hiding this comment.
| "ms": "2.1.3" | |
| "ms": "^2.1.3" |
to avoid the same problem in the future, using ^ will ensure it gets up to date with new minor/patch versions, which are backwards compatible
|
@SuperchupuDev last I checked, yes. I haven't seen any movement on the issues in a while. I need to go back and check again though, it's been a while. |
|
What's the problem with node and custom importers? Can you link the issues? |
|
@Qix- Could you please have a look here? It's been open for 3 years today. |
|
im not qix but @realityking can you take a look at my review suggestion? to avoid the same dependency problem in the future |
This is a minor update only containing stylistic changes: https://github.com/vercel/ms/releases/tag/2.1.3
It's nice to have so it doesn't show up as an outdated dependency & so it deduplicates with other libraries using it.