Add flag to force Node colors #713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the browser, `console.debug` does not output anything by default. From MDN (https://developer.mozilla.org/en-US/docs/Web/API/Console): "Starting with Chromium 58 this method only appears in Chromium browser consoles when level "Verbose" is selected."
artemave
added a commit
to featurist/electron-mocha
that referenced
this pull request
Jul 2, 2019
When/if [this pr](debug-js/debug#713) is merged, this change will allow to correctly output terminal colors from the [debug module](https://www.npmjs.com/package/debug) Also here: proxy all relevant renderer `console.*` methods to the main process `console`.
So that process that runs in Electron renderer process can log to the terminal if it runs in a headless mode, but to the browser console if it runs with the browser window. Use case: run browser tests in electron-mocha renderer with or without browser window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that process that runs in Electron renderer process can log to the terminal if it runs in a headless mode, but to the browser console if it runs with the browser window.
Use case: run browser tests in electron-mocha renderer with or without browser window and still have colors in both cases.
This change also FIXES MASTER. It changes default browser output from
console.debugtoconsole.logbecause the former seems to require a non-default log level to actually output things.https://developer.mozilla.org/en-US/docs/Web/API/Console :
