Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Date#toISOString() instead to Date#toUTCString() when output is n… #418

Closed
wants to merge 1 commit into from
Closed

Use Date#toISOString() instead to Date#toUTCString() when output is n… #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -76,7 +76,7 @@ Then, run the program to be debugged as usual.

![](http://f.cl.ly/items/2i3h1d3t121M2Z1A3Q0N/Screenshot.png)

When stdout is not a TTY, `Date#toUTCString()` is used, making it more useful for logging the debug information as shown below:
When stdout is not a TTY, `Date#toISOString()` is used, making it more useful for logging the debug information as shown below:

![](http://f.cl.ly/items/112H3i0e0o0P0a2Q2r11/Screenshot.png)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way this screenshot should also be updated, but I don't have to right term to do that.


Expand Down
2 changes: 1 addition & 1 deletion src/node.js
View file
Open in desktop
Expand Up @@ -114,7 +114,7 @@ function formatArgs(args) {
args[0] = prefix + args[0].split('\n').join('\n' + prefix);
args.push('\u001b[3' + c + 'm+' + exports.humanize(this.diff) + '\u001b[0m');
} else {
args[0] = new Date().toUTCString()
args[0] = new Date().toISOString()
+ ' ' + name + ' ' + args[0];
}
}
Expand Down