Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist DEBUG_FD for values 1 and 2 only Fixes #410 #415

Merged
merged 4 commits into from Jan 24, 2017
Merged

Whitelist DEBUG_FD for values 1 and 2 only Fixes #410 #415

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e580ef
Hide in DEBUG_FD deprecation warning in Webstorm Fixes #410
pi0 Jan 22, 2017
eb0bcad
Hide in DEBUG_FD deprecation warning in Webstorm Fixes #410
pi0 Jan 22, 2017
5350863
whitelist DEBUG_FD for values 1 and 2 only
Jan 23, 2017
2a8f8a4
Use appreciate depreciation message
Jan 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/node.js
View file
Open in desktop
Expand Up @@ -58,11 +58,12 @@ exports.inspectOpts = Object.keys(process.env).filter(function (key) {
* $ DEBUG_FD=3 node script.js 3>debug.log
*/

if ('DEBUG_FD' in process.env) {
util.deprecate(function(){}, '`DEBUG_FD` is deprecated. Override `debug.log` if you want to use a different log function (https://git.io/vMUyr)')()
var fd = parseInt(process.env.DEBUG_FD, 10) || 2;

if (1 !== fd && 2 !== fd) {
util.deprecate(function(){}, '`DEBUG_FD` is deprecated. Override `debug.log` if you want to use a different log function (https://git.io/debug_fd)')()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use a different message here, such as telling the user that using DEBUG_FD outside of file descriptors 1 and 2 is no longer supported or deprecated

}

var fd = parseInt(process.env.DEBUG_FD, 10) || 2;
var stream = 1 === fd ? process.stdout :
2 === fd ? process.stderr :
createWritableStdioStream(fd);
Expand Down