Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply latest Black to the repository #573

Merged
merged 3 commits into from Sep 11, 2020
Merged

Apply latest Black to the repository #573

merged 3 commits into from Sep 11, 2020

Conversation

BarisSari
Copy link
Contributor

@BarisSari BarisSari commented Sep 10, 2020

We don't specify the Black version in our requirements_dev.txt, and it has a new version that was released at the end of August (https://black.readthedocs.io/en/stable/change_log.html#b1). Therefore, Travis CI Build failed because there some changes (psf/black#1612). This PR makes this repository compatible with the latest Black version. It also solves flake8 warnings that occurred during the change.

I also updated pre-commit hook. Otherwise, it could try to revert all these changes. The following commands should upgrade the libraries of pre-commit hook:

pre-commit uninstall
pre-commit clean
pre-commit install

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #573 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #573   +/-   ##
========================================
  Coverage    98.94%   98.94%           
========================================
  Files           64       64           
  Lines         5955     5955           
========================================
  Hits          5892     5892           
  Misses          63       63           
Impacted Files Coverage Δ
importers/e_trac_importer.py 100.00% <ø> (ø)
importers/nisida_importer.py 100.00% <ø> (ø)
importers/replay_contact_importer.py 100.00% <ø> (ø)
importers/replay_importer.py 100.00% <ø> (ø)
pepys_admin/merge.py 99.64% <ø> (ø)
pepys_import/cli.py 100.00% <ø> (ø)
pepys_import/core/formats/rep_line.py 100.00% <ø> (ø)
pepys_import/core/store/sqlite_db.py 100.00% <ø> (ø)
pepys_import/core/validators/enhanced_validator.py 100.00% <ø> (ø)
pepys_import/file/file_processor.py 99.56% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34b487e...2918697. Read the comment docs.

@BarisSari BarisSari marked this pull request as ready for review September 10, 2020 12:39
Copy link
Member

@IanMayo IanMayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A huge piece of work @BarisSari

Thanks.

Copy link
Collaborator

@robintw robintw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@IanMayo IanMayo merged commit ad9caf8 into develop Sep 11, 2020
@IanMayo IanMayo deleted the apply_latest_black branch September 11, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants