Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-7862 Updated MongoDB connector docs to reflect replica_set connection mode removal #5556

Merged
merged 2 commits into from
May 24, 2024
Merged

DBZ-7862 Updated MongoDB connector docs to reflect replica_set connection mode removal #5556

merged 2 commits into from
May 24, 2024

Conversation

jcechace
Copy link
Member

https://issues.redhat.com/browse/DBZ-7862

@roldanbob Feel free to update as you see fit.

@jcechace jcechace requested a review from roldanbob May 12, 2024 15:35
@jcechace
Copy link
Member Author

Needs to be backported to 2.6!

roldanbob
roldanbob requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@roldanbob roldanbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and questions.

documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
@jcechace
Copy link
Member Author

@roldanbob Accepted all suggestions except for the two remaining

@github-actions GitHub Actions
Copy link

Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@roldanbob
Copy link
Contributor

@jcechace I updated my comments in response to your review.

@github-actions GitHub Actions
Copy link

Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@github-actions GitHub Actions
Copy link

Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@jcechace
Copy link
Member Author

@jpechane @roldanbob I've consolidated the changes. From my POV it can be merged.

roldanbob
roldanbob requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@roldanbob roldanbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jcechace I made another pass, and found a few more things.

documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
documentation/modules/ROOT/pages/connectors/mongodb.adoc Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

roldanbob
roldanbob approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@roldanbob roldanbob left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just saw your latest comment. Your latest comment makes sense. Updated the comment for L249, so if you implement that, I think we can merge this. Thanks.

roldanbob
roldanbob requested changes May 17, 2024
View reviewed changes
Copy link
Contributor

@roldanbob roldanbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I previously signaled approval for this, but then saw Jakub's comment about L249. After that change is committed, I think that this is ready to go.

@github-actions GitHub Actions
Copy link

Hi @jcechace, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key.

@jcechace @roldanbob
DBZ-7862 Applied docs suggestions from code review
6e741be 
Co-authored-by: roldanbob <broldan@redhat.com>
@jcechace jcechace merged commit c03dfa8 into debezium:main May 24, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpechane jpechane jpechane left review comments

@roldanbob roldanbob roldanbob requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jcechace @roldanbob @jpechane