Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-7797 Fail fast if surrogate key for incremental snapshot doesn't exist #5499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DBZ-7797 Fail fast if surrogate key for incremental snapshot doesn't exist #5499

wants to merge 1 commit into from

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Apr 19, 2024

@mfvitale
Copy link
Member

Hi @joschi thanks for the PR. I have only one concern: snapshot context may remain in an inconsistent state because of snapshotDataCollection and correlationId not cleared. Can you please check this scenario with an integration test?

@jpechane jpechane added the pending tests Tests running locally or internal CI, requires passing before merging. label May 29, 2024
@jpechane
Copy link
Contributor

@joschi Hi, would it be possible for you to provide the tests as recommend? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending tests Tests running locally or internal CI, requires passing before merging.
Projects
None yet
Milestone
No milestone
3 participants
@joschi @mfvitale @jpechane