Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBZ-7758 #5485

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DBZ-7758 #5485

wants to merge 2 commits into from

Conversation

PavelVrtal
Copy link

Work that still needs/could to be done before merge

  • use explicit Ehcache Serializers (instead of implementing native Java Serializable as of now) to avoid breaking immutable pattern on some data classes
  • only disk tier from Ehcache tiering options is used, so may be good to allow to configure heap tier as well
    -- Combination of heap and disk which we wanted for our use case turned out not to be working well, as the limit put on the heap was breached anyway (couldn't find out why) which led to OutOfMemoryError (we needed to limit the heap tier to less than 100 MB).
  • upgrade Ehcache dependency to 3.10: I ended up using Ehcache version 3.8.1 (I've tried also the latest one: 3.10, but encountered problems with dependencies which I couldn't resolve after spending some time on it)

FYI

  • Some refactoring had to be done because up until the introduction of Ehcache, all the implementations were Map-based, while Ehcache's Cache interface doesn't provide some of Map's methods.

Copy link

Welcome as a new contributor to Debezium, @PavelVrtal. Reviewers, please add missing author name(s) and alias name(s) to the COPYRIGHT.txt and Aliases.txt respectively.

@Naros Naros self-requested a review April 12, 2024 18:15
@Naros Naros self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants