DBZ-7297: Implement AWS IAM Authent in debezium-connector-postgres #5133
Conversation
...nnector-postgres/src/main/java/io/debezium/connector/postgresql/PostgresConnectorConfig.java
Outdated
Show resolved
Hide resolved
| private static Logger LOGGER = LoggerFactory.getLogger(PostgresConnection.class); | ||
|
|
||
| private static final String URL_PATTERN = "jdbc:postgresql://${" + JdbcConfiguration.HOSTNAME + "}:${" | ||
| private static final String URL_PATTERN_WITHOUT_PROTOCOL = "${" + JdbcConfiguration.HOSTNAME + "}:${" |
There was a problem hiding this comment.
Is not it possible to pass the protocol as pattern placeholder?
There was a problem hiding this comment.
I need to change the JDBCConfiguration to do this, which is widely used, so it's simpler to me to do like this :)
…r/postgresql/PostgresConnectorConfig.java Co-authored-by: Jiri Pechanec <jpechane@redhat.com>
|
Hi @bpaquet, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key. |
|
@bpaquet I think we can sill salvage the PR even if it will not cover all the situations. I'd recommend to add an integration test that will be using the JDBC URL passed as an config option. Then after the merge we can think about merging Oracle, MySQL and PostgreSQL config options and allow all relational connectors to pass arbitrary JDBC connection string. |
|
Hi @bpaquet, thanks for your contribution. Please prefix the commit message(s) with the DBZ-xxx JIRA issue key. |
|
This looks great, we also have a need to leverage IAM authentication to our RDS postgres. Any updates on the status of this being merged in? |
|
Hello, I'm stucked because IAM authent is not supported by Aurora, only by
standard RDS. I'm not able to test.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/UsingWithRDS.IAMDBAuth.html#UsingWithRDS.IAMDBAuth.Limitations
Are you using Aurora or RDS?
…On Thu, Apr 25, 2024 at 11:24 PM Jake Heath ***@***.***> wrote:
This looks great, we also have a need to leverage IAM authentication to
our RDS postgres. Any updates on the status of this being merged in?
—
Reply to this email directly, view it on GitHub
<#5133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACSJXLOK565ECIKSBEDYNLY7FX7VAVCNFSM6AAAAABBKBQ2MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGE4TSNRQGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ah, we are use RDS Aurora as well. This is the line you are referring to?
|
|
Yes :(
…On Thu, Apr 25, 2024 at 11:54 PM Jake Heath ***@***.***> wrote:
Ah, we are use RDS Aurora as well. This is the line you are referring to?
For Aurora PostgreSQL, you cannot use IAM authentication to establish a
replication connection.
—
Reply to this email directly, view it on GitHub
<#5133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACSJXN33L5W6QEU5LZKLWDY7F3QBAVCNFSM6AAAAABBKBQ2MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZYGIZTMOJRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Allow to use IAM authent with the custom AWS Driver: https://github.com/awslabs/aws-advanced-jdbc-wrapper.
I choose to not change the
JDBCConfigurationclass, because the change was too wide. So I just created a factory method to handle the two new params.